Skip to content

k8s content image: Image from PR should not be tagged latest #11643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhmdnd merged 2 commits into from
Mar 4, 2024
Merged

k8s content image: Image from PR should not be tagged latest #11643

rhmdnd merged 2 commits into from
Mar 4, 2024

Conversation

@yuumasato
Copy link
Member

@yuumasato yuumasato commented Mar 1, 2024 •
edited
Loading

Description:

Rationale:

Review Hints:

yuumasato added 2 commits March 1, 2024 16:18
@yuumasato
k8s content images: Don't tag PR images as latest
148107d 
Add tag flavors input as false.
The images built from a PR are not to receive the latest tag.
@yuumasato
k8s content image: Comment the commit used
4293530 
Output in the comment what commit was used to build the image.
@yuumasato yuumasato requested a review from Vincent056 March 1, 2024 16:36
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 1, 2024

Code Climate has analyzed commit 4293530 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Mar 1, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11643

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11643

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11643 make deploy-local

@yuumasato yuumasato requested a review from rhmdnd March 4, 2024 10:22
@yuumasato yuumasato added the OpenShift OpenShift product related. label Mar 4, 2024
@rhmdnd rhmdnd merged commit a50839a into ComplianceAsCode:master Mar 4, 2024
@yuumasato yuumasato deleted the pr_content_images_are_not_latest branch March 4, 2024 16:30
@yuumasato yuumasato added this to the 0.1.73 milestone Mar 4, 2024
@yuumasato
Copy link
Member Author

yuumasato commented Mar 5, 2024

The latest tag is still being added to images from PRs.
But the the commit sha is being printed correctly:
#11638 (comment)

@rhmdnd
Copy link
Collaborator

rhmdnd commented Mar 5, 2024

The latest tag is still being added to images from PRs. But the the commit sha is being printed correctly: #11638 (comment)

I think @Vincent056 is working on something to fix the deployment using latest.

@yuumasato
Copy link
Member Author

yuumasato commented Apr 12, 2024

@Vincent056 It seems that the latest is being correctly added now. Did you do something to fix it?

@Mab879 Mab879 added Infrastructure Our content build system labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

@Vincent056 Vincent056 Awaiting requested review from Vincent056

Assignees

@rhmdnd rhmdnd

Labels

Infrastructure Our content build system OpenShift OpenShift product related.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

3 participants

@yuumasato @rhmdnd @Mab879