Skip to content

Fix description for auditd_max_log_file_action #11585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jan-cerny merged 1 commit into from
Feb 15, 2024
Merged

Fix description for auditd_max_log_file_action #11585

jan-cerny merged 1 commit into from
Feb 15, 2024

Conversation

@mpurg
Copy link
Contributor

@mpurg mpurg commented Feb 13, 2024

Description:

  • Replace hardcoded value rotate with variable var_auditd_max_log_file_action.

Rationale:

  • Many profiles use values other than 'rotate', such as keep_logs and syslog.

@mpurg
Fix description for auditd_max_log_file_action
a783b7f 
Replace hardcoded value 'rotate' with variable var_auditd_max_log_file_action.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 13, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Feb 13, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Feb 13, 2024

Code Climate has analyzed commit a783b7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Feb 14, 2024
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Feb 14, 2024
@jan-cerny jan-cerny added this to the 0.1.73 milestone Feb 14, 2024
@jan-cerny
Copy link
Collaborator

jan-cerny commented Feb 14, 2024

/packit retest-failed

1 similar comment
@jan-cerny
Copy link
Collaborator

jan-cerny commented Feb 14, 2024

/packit retest-failed

@jan-cerny jan-cerny merged commit 1a3d088 into ComplianceAsCode:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels

needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

2 participants

@mpurg @jan-cerny