-
Notifications
You must be signed in to change notification settings - Fork 765
OCP4: Update k8s action to build image on new PR #11384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
04c843e to
87f31c1
Compare
|
/packit retest-failed |
|
I think this worked: ghcr.io/complianceascode/k8scontent:11384 |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was able to deploy the content by doing: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11384 make deploy-local
And how about, for visibility purposes, posting a comment to the PR?
For example, the final tasks of this workflow post a comment to the PR:
content/.github/workflows/compare-ds.yaml
Line 90 in 41ad190
| - name: Find Comment |
|
🤖 The image for this PR is available at ghcr.io/complianceascode/k8scontent: |
This triggers action to run on every new PR created
|
🤖 The image for this PR is available at ghcr.io/complianceascode/k8scontent:11384 |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vincent056 One more round and should be excelent
Co-authored-by: Watson Yuuma Sato <wsato@redhat.com>
Add a new line to EOF
|
Code Climate has analyzed commit 59f3f8f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
|
🤖 The image for this PR is available at: |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
|
/hold for test |
|
/lgtm make images && make push && make catalog && make catalog-deploymake images && make push && make deploy" |
|
/unhold |
|
Test |
This triggers the K8S image action to run on every new PR created