Skip to content

Conversation

@Vincent056
Copy link
Contributor

This triggers the K8S image action to run on every new PR created

@Vincent056 Vincent056 changed the title OCP4: Update k8s action to build image on new PR WIP OCP4: Update k8s action to build image on new PR Dec 13, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Dec 13, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Vincent056 Vincent056 force-pushed the action branch 7 times, most recently from 04c843e to 87f31c1 Compare December 14, 2023 07:16
@Mab879
Copy link
Member

Mab879 commented Dec 14, 2023

/packit retest-failed

@Vincent056
Copy link
Contributor Author

I think this worked: ghcr.io/complianceascode/k8scontent:11384

@Vincent056 Vincent056 changed the title WIP OCP4: Update k8s action to build image on new PR OCP4: Update k8s action to build image on new PR Dec 14, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Dec 14, 2023
@marcusburghardt marcusburghardt added OpenShift OpenShift product related. Infrastructure Our content build system labels Dec 15, 2023
@marcusburghardt marcusburghardt added this to the 0.1.72 milestone Dec 15, 2023
@yuumasato yuumasato self-assigned this Dec 20, 2023
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was able to deploy the content by doing: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11384 make deploy-local

And how about, for visibility purposes, posting a comment to the PR?
For example, the final tasks of this workflow post a comment to the PR:

- name: Find Comment

@github-actions
Copy link

🤖 The image for this PR is available at ghcr.io/complianceascode/k8scontent:

This triggers action to run on every new PR created
@github-actions
Copy link

🤖 The image for this PR is available at ghcr.io/complianceascode/k8scontent:11384

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vincent056 One more round and should be excelent

Co-authored-by: Watson Yuuma Sato <wsato@redhat.com>
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 59f3f8f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@github-actions
Copy link

🤖 The image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11384

@Vincent056 Vincent056 requested a review from yuumasato January 17, 2024 08:08
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@xiaojiey
Copy link
Collaborator

/hold for test

@openshift-ci openshift-ci bot added the do-not-merge/hold Used by openshift-ci-robot bot. label Jan 19, 2024
@xiaojiey
Copy link
Collaborator

/lgtm
tried before commands to deploy pb with the custom content image
"export CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11384

make images && make push && make catalog && make catalog-deploy

make images && make push && make deploy"
$ oc get pb
NAME CONTENTIMAGE CONTENTFILE STATUS
ocp4 ghcr.io/complianceascode/k8scontent:11384 ssg-ocp4-ds.xml VALID
rhcos4 ghcr.io/complianceascode/k8scontent:11384 ssg-rhcos4-ds.xml VALID

@xiaojiey
Copy link
Collaborator

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Used by openshift-ci-robot bot. label Jan 19, 2024
@yuumasato
Copy link
Member

Test Gate / Build, Test on Debian 10 (Container) (push) has been failing consistently, although I see it passing in other PRs.
This patch doesn't affect Debian builds in any way, so I'm merging.
Thank you @Vincent056

@yuumasato yuumasato merged commit 64bdbd1 into master Jan 19, 2024
@yuumasato yuumasato deleted the action branch January 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Our content build system OpenShift OpenShift product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants