Skip to content

Conversation

@Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 30, 2023

Description:

  • Ignore mypy in the EOF Checker
  • Add some type hints

Rationale:

  • Remove race condition from the tests
  • Add more types hints for mypy to check

@Mab879 Mab879 added the Infrastructure Our content build system label Nov 30, 2023
@Mab879 Mab879 added this to the 0.1.72 milestone Nov 30, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit f68bead and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt
Copy link
Member

marcusburghardt commented Dec 1, 2023

testing-farm failures are not related to this PR and can be safely waived here.

@marcusburghardt marcusburghardt merged commit 3c3b708 into ComplianceAsCode:master Dec 1, 2023
@marcusburghardt marcusburghardt self-assigned this Dec 1, 2023
@Mab879 Mab879 deleted the ignore_mypy_eof branch December 1, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Our content build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants