Skip to content

Remove DRAFT wording for OpenShift STIG #11100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhmdnd merged 1 commit into from
Sep 8, 2023
Merged

Remove DRAFT wording for OpenShift STIG #11100

rhmdnd merged 1 commit into from
Sep 8, 2023

Conversation

@rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Sep 8, 2023

The OpenShift STIG was published by DISA:

https://public.cyber.mil/stigs/downloads/

This commit removes the draft wording from the STIG profile for
OpenShift, since it's publicly available.

Vincent056
Vincent056 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Mab879 Mab879 added this to the 0.1.70 milestone Sep 8, 2023
@Mab879 Mab879 added OpenShift OpenShift product related. STIG STIG Benchmark related. Highlight This PR/Issue should make it to the featured changelog. labels Sep 8, 2023
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Sep 8, 2023

/test

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

@rhmdnd: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-images
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Sep 8, 2023

/test e2e-aws-ocp4-stig
/test e2e-aws-ocp4-stig-node
/test e2e-aws-rhcos4-stig

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rhmdnd
Remove DRAFT wording for OpenShift STIG
8d4cd80 
The OpenShift STIG was published by DISA:

  https://public.cyber.mil/stigs/downloads/

This commit removes the draft wording from the STIG profile for
OpenShift, since it's publicly available.
@rhmdnd rhmdnd force-pushed the remove-draft-from-ocp-stig branch from fa49d62 to 8d4cd80 Compare September 8, 2023 19:03
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Sep 8, 2023

/test e2e-aws-ocp4-stig
/test e2e-aws-ocp4-stig-node
/test e2e-aws-rhcos4-stig

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Sep 8, 2023

Code Climate has analyzed commit 8d4cd80 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@rhmdnd rhmdnd merged commit 7c741f2 into ComplianceAsCode:master Sep 8, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vincent056 Vincent056 Vincent056 approved these changes

Assignees

@rhmdnd rhmdnd

Labels

Highlight This PR/Issue should make it to the featured changelog. OpenShift OpenShift product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.70

Development

Successfully merging this pull request may close these issues.

3 participants

@rhmdnd @Vincent056 @Mab879