Skip to content

Fix path for aide to /etc/aide/aide.conf for UBTU-20-010205 #11066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dodys merged 1 commit into from
Oct 18, 2023
Merged

Fix path for aide to /etc/aide/aide.conf for UBTU-20-010205 #11066

dodys merged 1 commit into from
Oct 18, 2023

Conversation

@dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 7, 2023 •
edited
Loading

Description:

  • Fix UBTU-20-010205
  • Use aide_conf_path for Ansible remediation instead of hardcoding aide config path

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010205"

To test changes with bash, run the remediation section: xccdf_org.ssgproject.content_rule_aide_check_audit_tools

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can not be tested with the latest Ubuntu 2004 Benchmark SCAP. Please perform manual check with the given check text. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added Ansible Ansible remediation update. Update Rule Issues or pull requests related to Rules updates. STIG STIG Benchmark related. and removed STIG STIG Benchmark related. labels Sep 8, 2023
@dodys dodys added the STIG STIG Benchmark related. label Sep 8, 2023
@dexterle dexterle marked this pull request as ready for review September 11, 2023 13:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
@dodys dodys requested a review from a team September 12, 2023 20:49
@dodys dodys self-assigned this Sep 12, 2023
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Sep 12, 2023
@dexterle
Fix path for aide to /etc/aide/aide.conf for UBTU-20-010205
d014ac7 
This commit will fix the path from /etc/aide.conf to /etc/aide/aide.conf by adding in jinja conditional
@dexterle dexterle force-pushed the fix-rule-ubtu-20-010205 branch from 24602c8 to d014ac7 Compare September 13, 2023 18:05
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Sep 13, 2023

Code Climate has analyzed commit d014ac7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Sep 14, 2023
@Mab879 Mab879 modified the milestones: 0.1.70, 0.1.71 Oct 2, 2023
dodys
dodys approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 5973a7a into ComplianceAsCode:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@dodys dodys

Labels

Ansible Ansible remediation update. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.71

Development

Successfully merging this pull request may close these issues.

4 participants

@dexterle @dodys @marcusburghardt @Mab879