Skip to content

Fix UBTU-20-10450 STIG #11058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dodys merged 1 commit into from
Sep 12, 2023
Merged

Fix UBTU-20-10450 STIG #11058

dodys merged 1 commit into from
Sep 12, 2023

Conversation

@dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 7, 2023 •
edited
Loading

Description:

  • Fix UBTU-20-010450
  • Add rule target in stig profile

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010450"

To test changes with bash, run the remediation section: xccdf_org.ssgproject.content_rule_aide_build_database and xccdf_org.ssgproject.content_rule_package_aide_installed

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can be tested with the latest Ubuntu 2004 Benchmark SCAP. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Sep 8, 2023
@dodys dodys self-assigned this Sep 8, 2023
@dexterle dexterle marked this pull request as ready for review September 11, 2023 12:40
@dexterle dexterle requested a review from a team as a code owner September 11, 2023 12:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
dodys
dodys requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fix needed

@dexterle dexterle mentioned this pull request Sep 11, 2023
Merged
@dexterle
Fix UBTU-20-10450 STIG
275018e 
This commit will fix bug with UBTU-20-10450 STIG which makes sure to initalize database.
@dexterle dexterle force-pushed the fix-rules-ubtu-20-10450 branch from 96da504 to 275018e Compare September 12, 2023 18:09
dodys
dodys approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Sep 12, 2023

Code Climate has analyzed commit 275018e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@dodys dodys merged commit dcec4c9 into ComplianceAsCode:master Sep 12, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 12, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.70

Development

Successfully merging this pull request may close these issues.

4 participants

@dexterle @dodys @Mab879 @marcusburghardt