Skip to content

Handle 'CanExecute' with method overrides #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

Handle 'CanExecute' with method overrides #1081

merged 1 commit into from
Nov 6, 2025

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented May 9, 2025

This PR fixes an issue where the [RelayCommand] generator doesn't account for method overrides for CanExecute.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug analyzer 👓 A new analyzer being implemented or updated labels May 9, 2025
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/handle-canexecute-overrides branch 3 times, most recently from ab09e62 to f352f60 Compare November 6, 2025 04:07
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/handle-canexecute-overrides branch from f352f60 to 7d4d6ec Compare November 6, 2025 18:33
@Sergio0694 Sergio0694 merged commit 2388b9a into main Nov 6, 2025
5 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/handle-canexecute-overrides branch November 6, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

analyzer 👓 A new analyzer being implemented or updated bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sergio0694