Skip to content

Conversation

@W0rma
Copy link
Contributor

@W0rma W0rma commented Nov 8, 2024

PHP 8.4 deprecates the E_STRICT error level constant.
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant

This PR removes the constant from the internal test suite and the default configuration.

For the error handler the constant is only used for PHP 8.3 or lower.

Furthermore, tests against PHP 8.4 are enabled in the CI.

@W0rma W0rma marked this pull request as ready for review November 8, 2024 15:03
@W0rma
Copy link
Contributor Author

W0rma commented Nov 29, 2024

@Naktibalda @SamMousa Please let me know if I can assist to get this merged.

It would be great to have a new Codeception release after this PR is merged.
This way Codeception can be used with PHP 8.4 without deprecation warnings.

@SamMousa SamMousa merged commit 3e57474 into Codeception:main Nov 29, 2024
10 checks passed
@W0rma W0rma deleted the php84-e-strict branch November 29, 2024 18:03
@indy2kro
Copy link

Any idea when next released is scheduled to benefit from this change at least?

@W0rma W0rma mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants