Skip to content

Conversation

@adrenalinkin
Copy link
Contributor

closes #6760

Add some new option --disable-coverage-php this will not provoke BC changes

php bin/codecept run unit --coverage --coverage-html --disable-coverage-php

@SamMousa
Copy link
Collaborator

SamMousa commented Sep 11, 2024

LGTM.

Any reason we cannot use --coverage-php with a default value of true?
To keep it consistent with the other coverage outputs?

@adrenalinkin
Copy link
Contributor Author

@SamMousa Hello! Did you read issue #6760?
I don't want to break compatibility in CLI. let's see examples:

AS IS

php bin/codecept run unit --coverage-html will generate PHP report + HTML Report
php bin/codecept run unit --coverage will generate PHP report

Version with --coverage-php

php bin/codecept run unit --coverage-html will generate only HTML Report BC changes
php bin/codecept run unit --coverage will generate IDK What - need suggestions
php bin/codecept run unit --coverage-php will generate only PHP Report

Version with --disable-coverage-php

php bin/codecept run unit --coverage-html will generate PHP report + HTML Report No BC
php bin/codecept run unit --coverage will generate only PHP Report No BC
php bin/codecept run unit --coverage-html --disable-coverage-php will generate only HTML Report

@SamMousa
Copy link
Collaborator

I did read it. Makes sense. Can you recreate the PR targeted at the main branch?

@adrenalinkin adrenalinkin changed the base branch from 5.1 to main September 13, 2024 08:39
@adrenalinkin adrenalinkin changed the base branch from main to 5.1 September 13, 2024 08:51
# Conflicts:
#	src/Codeception/Command/Run.php
@adrenalinkin adrenalinkin changed the base branch from 5.1 to main September 13, 2024 08:58
@adrenalinkin
Copy link
Contributor Author

@SamMousa Done

@SamMousa SamMousa merged commit d80057c into Codeception:main Sep 13, 2024
@adrenalinkin
Copy link
Contributor Author

@SamMousa Pls don't forget merge documentation update
Codeception/codeception.github.com#864

@adrenalinkin adrenalinkin deleted the ISSUE-6760 branch September 13, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to disable coverage.serialized report and reduce memory usage.

2 participants