Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@NathanielRose
Copy link
Collaborator

@NathanielRose NathanielRose commented Mar 31, 2020

@NathanielRose NathanielRose changed the title Manage Identity Environment and Testing docs Bedrock Manage Identity Environment and Testing docs Mar 31, 2020
Copy link
Contributor

@sarath-p sarath-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to update the text.

- Provide detection, abort, and reporting of deployment status when a failure
occurs.

![](infratestflow.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to update the diagram to reflect the below steps. Also change the "4 key functionalities" to "4 key steps"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to lines 86-93?
They are included in the diagram as sections

Copy link

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @NathanielRose. Nice work!

Left some questions and minor comments.

telemetry from the deployment process for monitoring of ongoing pipeline
performance and diagnosis of any deployment failures
- Support deployment into multiple staging environments
- Execute automated unit-level and integration-level tests against the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not run the integration tests directly against the fixed environments?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to get your input here:

If a “unit” in Terraform is a single module, an integration test that validates how several units work together would need to deploy several modules and see that they work correctly. We're first testing to replicate deployment to achieve the state on our expected stage. Then we run a terraform apply in our QA stage to verify success with live resources. There is a possibility to bypass provisioned integration on certain changes.

@erikschlegel erikschlegel self-requested a review April 8, 2020 19:58
@NathanielRose NathanielRose merged commit ca6f7e9 into CatalystCode:master Apr 8, 2020
@NathanielRose NathanielRose deleted the nate.design.MSI branch April 8, 2020 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design Document for MSI Template for verfied validation within Bedrock

5 participants