-
Notifications
You must be signed in to change notification settings - Fork 16
Bedrock Manage Identity Environment and Testing docs #481
Bedrock Manage Identity Environment and Testing docs #481
Conversation
sarath-p
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments to update the text.
| - Provide detection, abort, and reporting of deployment status when a failure | ||
| occurs. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to update the diagram to reflect the below steps. Also change the "4 key functionalities" to "4 key steps"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to lines 86-93?
They are included in the diagram as sections
erikschlegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @NathanielRose. Nice work!
Left some questions and minor comments.
| telemetry from the deployment process for monitoring of ongoing pipeline | ||
| performance and diagnosis of any deployment failures | ||
| - Support deployment into multiple staging environments | ||
| - Execute automated unit-level and integration-level tests against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not run the integration tests directly against the fixed environments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious to get your input here:
If a “unit” in Terraform is a single module, an integration test that validates how several units work together would need to deploy several modules and see that they work correctly. We're first testing to replicate deployment to achieve the state on our expected stage. Then we run a terraform apply in our QA stage to verify success with live resources. There is a possibility to bypass provisioned integration on certain changes.
Uh oh!
There was an error while loading. Please reload this page.