Implement a Patcher Rewrite #1964
Open
+359
−388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 2 new options * `displayName`: A string that represents the name of that given patch. This will be shown when an exception is thrown within the patch (default is the function name or `Anonymous`) * `priority`: A number that defines the priority of that patch, higher number increases the priority and lower number number lowers the priority (default is 0) Also fixes typos and adds the patch details to the handler object of the proxy
Adds a option to prevent the patch being unpatched via `unpatchAll`. To unpatch you must manually unpatch via the returned function or the once option
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a complete rewrite of the Patcher module with enhanced memory safety and new functionality. The rewrite introduces a new getOriginal function to retrieve unpatched functions and adds options for more granular patching behavior.
- Complete rewrite of the patcher implementation using WeakMaps for better memory management
- Added
getOriginalfunction to access original unpatched functions - Introduced options system with
once,forcePatch,displayName,priority, anddetachedparameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/betterdiscord/modules/patcher.ts | Complete rewrite of the core patcher logic with new hook-based system and enhanced type safety |
| src/betterdiscord/api/patcher.ts | Updated API wrapper to support new options parameter and integrate with rewritten patcher |
Member
|
I think this is something that could use more testing before merging |
Because the checking is only done on the plugin api, its possible for patcher to throw a exception for bd internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully more memory safe version of the patcher.
Also adds a new function called
getOriginalwhen called it'll return the original functionAdds options when patching
once: Whentrue(default isfalse) it will instantly unpatch after the callback is ranforcePatch: Whenfalse(default istrue) and when you go to patch a function that doesn't exist on the module, it will not add the function