Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner October 31, 2025 21:49
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cspell package configuration to standardize the package naming and pin the exact version. The changes rename the package to use the @azure-tools scope, mark it as private, and pin the cspell dependency to an exact version rather than using a caret range.

Key Changes:

  • Renamed package from "cspell-version-pin" to "@azure-tools/cspell"
  • Added "private": true to prevent accidental publication
  • Changed cspell dependency from ^9.2.1 (caret range) to 9.2.1 (exact version)

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/common/spelling/package.json Updated package name to scoped name, added private flag, and pinned cspell to exact version
eng/common/spelling/package-lock.json Synchronized lock file with package.json changes for name and version pinning
Files not reviewed (1)
  • eng/common/spelling/package-lock.json: Language not supported

{
"name": "cspell-version-pin",
"name": "@azure-tools/cspell",
"version": "1.0.0",
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version field should be removed from package-lock.json when the package is marked as private and not intended for publication, or it should be kept in sync with package.json. Currently, package.json is missing the version field but package-lock.json still includes it, creating an inconsistency.

Suggested change
"version": "1.0.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants