Sync eng/common directory with azure-sdk-tools for PR 12516 #6813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the release plan creation instructions to streamline the workflow and improve clarity. The main change is removing the "Check Existing Release Plan" step and renumbering subsequent steps accordingly.
- Updated critical instructions header for LLM with additional guidance on following NextSteps
- Removed Step 2 (Check Existing Release Plan) to simplify the workflow
- Renumbered all subsequent steps (Step 3-7 became Step 2-6)
| > Backend processes may use Azure DevOps work item data as needed. However, do **not** mention or display the work item link/URL, or any reference to Azure DevOps work item resources directly in conversation with the user. | ||
| > All manual updates to an existing release plan must be made through the [Release Planner Tool](https://aka.ms/sdk-release-planner) to ensure proper tracking and validation. | ||
| > Only provide release plan details such as **Release Plan Link** and **Release Plan ID** to the user | ||
| > **CRITICAL INSTRUCTIONS FOR LLM*** |
There was a problem hiding this comment.
Extra asterisk at the end of the heading. Should be 'LLM**' instead of 'LLM***'.
Suggested change
| > **CRITICAL INSTRUCTIONS FOR LLM*** | |
| > **CRITICAL INSTRUCTIONS FOR LLM** |
| > 4. Always check the `NextSteps` field in the tool response and follow any additional prompts provided. Do NOT proceed to other steps until the NextSteps are completed. | ||
| # Release Plan Creation Process | ||
| Your goal is to create a valid release plan. You must prompt user to provide all required information and all input must match the format and requirement mentioned in step 3 below. |
There was a problem hiding this comment.
The reference to 'step 3' is now incorrect after renumbering. Since Step 3 became Step 2, this should reference 'step 2' or be updated to avoid hardcoded step numbers that can become stale.
Suggested change
| Your goal is to create a valid release plan. You must prompt user to provide all required information and all input must match the format and requirement mentioned in step 3 below. | |
| Your goal is to create a valid release plan. You must prompt user to provide all required information and all input must match the format and requirement mentioned in step 2 below. |
Comment on lines
31
to
33
| - Once all information is gathered, use `azsdk_create_release_plan` to create the release plan | ||
| - If existing release plans are found, extract and display key information: Release Plan ID, status, associated languages, SDK PRs | ||
| - Display the newly created release plan details to the user for confirmation |
There was a problem hiding this comment.
This instruction about handling existing release plans seems orphaned after removing Step 2 (Check Existing Release Plan). The workflow no longer has a dedicated step to check for existing plans before Step 3 creates one, making this instruction unclear about when/how existing plans would be found.
Suggested change
| - Once all information is gathered, use `azsdk_create_release_plan` to create the release plan | |
| - If existing release plans are found, extract and display key information: Release Plan ID, status, associated languages, SDK PRs | |
| - Display the newly created release plan details to the user for confirmation | |
| - Once all information is gathered, use `azsdk_create_release_plan` to create the release plan. This tool will automatically check for existing release plans matching the provided details. | |
| - If the tool finds existing release plans, extract and display key information: Release Plan ID, status, associated languages, SDK PRs. | |
| - If a new release plan is created, display its details to the user for confirmation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12516 See eng/common workflow