Skip to content

Conversation

@dstocco
Copy link
Contributor

@dstocco dstocco commented Jan 5, 2021

The object was passed as an argument, but not used in the end.
This PR fixes it.

@dstocco dstocco requested a review from aphecetche as a code owner January 5, 2021 10:18
@aphecetche
Copy link
Collaborator

@davidrohr I assume the CUDA error from build/O2/fullCI is known and being resolved ? (and is unrelated to this PR)

@davidrohr
Copy link
Collaborator

@TimoWilken : The CUDA problem had been fixed by alisw/ali-bot@652ab06 yesterday. Do you have any idea why it fails now in the O2 CI? Is it possible that this change was not picked up by all builders? Or was something changed wrt. the GPU CI container?

@TimoWilken
Copy link
Contributor

@davidrohr I hadn't restarted the builders to avoid delays, so they were still running in the old container (which has CUDA under /opt). I'll restart them this evening.

@davidrohr
Copy link
Collaborator

But this I don't understand. Yesterday I saw the problem that CUDA was not found, so I changed the location in the ali-bot script. But this is only possible if the builders were using the new container. So this means currently some are using the old and some are using the new one?

@TimoWilken
Copy link
Contributor

@davidrohr Hm, that's odd, one of the three workers has CUDA under /opt, the other two have it under /usr/local/bin. Maybe a docker pull failed somewhere. I'll restart the old one now.

@aphecetche aphecetche merged commit a915434 into AliceO2Group:dev Jan 6, 2021
@dstocco dstocco deleted the fixdecoder branch January 7, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants