[DPL Analysis] Helper to create partitions in process() + extended expressions to int64_t #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Adding |
Collaborator
Author
Hm, strangely it fails for me without int64_t. It says e.g. that cannot match T = long int to any of other LiteralNode variants. |
Member
True, this is not an index column but rather the index counter, that one is indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jgrosseo , this is the example for partitions.
groupedTracks.bindTable(tracks);does the actual job.For comparison with index columns I extended expression nodes to accept int64_t - @aalkin , is that OK for you?