Skip to content

Conversation

@nzardosh
Copy link
Contributor

further chnages for PreSel

adding final touches

adding histograms

correct vertex reconstruction

adding Jpsitoee

@nzardosh
Copy link
Contributor Author

nzardosh commented Nov 19, 2020

This pull request requires a review before merging

Adding preselection for Lc->pKpi, Ds->KKpi and Jpsi->ee
Adding bitmaps for which hadrons are selected
Optimising code for easy addition of decays
Adding a class for preselection configurables
Adding histogram registry
Changing which selections are made before and after the vertex finding
Making independent the 2 and 3 prong secondary vertex finding
Fixing the 2 and 3 prong track selection and changing the track selection table
Adding skeleton for centrality option to be used later
Adding debug option for a more detailed table of which selections were satisfied for each hadron

@nzardosh nzardosh force-pushed the HFPreSel branch 2 times, most recently from 0355173 to c5beaa1 Compare November 19, 2020 16:09
@nzardosh nzardosh changed the title HF PreSelection Changes PWGHF PreSelection Changes Nov 19, 2020
@ginnocen ginnocen changed the title PWGHF PreSelection Changes DO NOT MERGE YET: PWGHF PreSelection Changes Nov 19, 2020
@ginnocen ginnocen changed the title DO NOT MERGE YET: PWGHF PreSelection Changes PWGHF: DO NOT MERGE YET, PreSelection Changes Nov 19, 2020
iarsene
iarsene previously approved these changes Nov 20, 2020
// 2-prong cuts Jpsi
double mPtJpsiMin = 0.;
double mInvMassJpsiMin = 2.75;
double mInvMassJpsiMax = 3.45;
Copy link
Collaborator

@iarsene iarsene Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for the minimum mass would probably be safer to have it lower. Thats because of the radiative jpsi tail and also because we normally use ee pairs with lower masses to estimate decay length for background pairs. So here i would suggest 2.50 as default

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @iarsene, thanks for the useful comment. I was wondering if at this point we should also increase the upper limit to include the psi(2S) peak, meaning get to 4.1 or so. I would say it should not substantially increase the size. It could be useful to measure that psi(2S) channel, but also to subtract it from the J/psi background shape. Let us know what you think. Cheers GM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ginnocen,
Sure, this can be extended to include psi2S as well. I would say that going up to 4.0 would be fine.
Cheers, Ionut

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @iarsene. we will include this in the next fix. cheers GM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the information, this has been updated

@vkucera
Copy link
Collaborator

vkucera commented Nov 21, 2020

Please replace the PR description with a summary list of specific things that changed or were added.

@@ -0,0 +1,186 @@
// Copyright CERN and copyright holders of ALICE O2. This software is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nzardosh, to make sure I understand the goal of this HFConfigurables.h. This .h will contain all the default parameters of the preselection cuts, which were previously set directly inside the task. They will be overwritten if a proper JSON file is given to the task. Do I understand it right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed this is correct


double getPtD0Min() const
{
return mPtD0Min;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is allowed in such cases to make the variables themselves public and skip the getters...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i have changed this

Copy link
Contributor Author

@nzardosh nzardosh Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgrosseo out of interest if I try to access these in the struct but outside the process function, would it be possible without the getters?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be JpsiToEEFlag, jpsiToEEFlag to be consistent with the rest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, I will change it

@nzardosh nzardosh force-pushed the HFPreSel branch 3 times, most recently from 6d0972d to c6324b7 Compare November 25, 2020 17:39
@nzardosh nzardosh changed the title PWGHF: DO NOT MERGE YET, PreSelection Changes PWGHF: DO NOT MERGE YET, PreSelection Changes (Added LctopKpi, Ds and Jpsi preselection, Optimisation of code structure, use of bitwise values to keep track of preselection) Nov 25, 2020
@nzardosh nzardosh changed the title PWGHF: DO NOT MERGE YET, PreSelection Changes (Added LctopKpi, Ds and Jpsi preselection, Optimisation of code structure, use of bitwise values to keep track of preselection) PWGHF: DO NOT MERGE YET, PreSelection Changes Nov 26, 2020
further chnages for PreSel

adding final touches

adding histograms

correct vertex reconstruction

adding Jpsitoee

adding debug option

mend
@ginnocen ginnocen changed the title PWGHF: DO NOT MERGE YET, PreSelection Changes PWGHF: PreSelection Changes Dec 2, 2020
@jgrosseo jgrosseo merged commit 2acbe99 into AliceO2Group:dev Dec 2, 2020
@nzardosh nzardosh deleted the HFPreSel branch January 15, 2021 18:35
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants