-
Notifications
You must be signed in to change notification settings - Fork 485
PWGHF: PreSelection Changes #4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request requires a review before merging Adding preselection for Lc->pKpi, Ds->KKpi and Jpsi->ee |
0355173 to
c5beaa1
Compare
| // 2-prong cuts Jpsi | ||
| double mPtJpsiMin = 0.; | ||
| double mInvMassJpsiMin = 2.75; | ||
| double mInvMassJpsiMax = 3.45; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for the minimum mass would probably be safer to have it lower. Thats because of the radiative jpsi tail and also because we normally use ee pairs with lower masses to estimate decay length for background pairs. So here i would suggest 2.50 as default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @iarsene, thanks for the useful comment. I was wondering if at this point we should also increase the upper limit to include the psi(2S) peak, meaning get to 4.1 or so. I would say it should not substantially increase the size. It could be useful to measure that psi(2S) channel, but also to subtract it from the J/psi background shape. Let us know what you think. Cheers GM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ginnocen,
Sure, this can be extended to include psi2S as well. I would say that going up to 4.0 would be fine.
Cheers, Ionut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @iarsene. we will include this in the next fix. cheers GM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the information, this has been updated
|
Please replace the PR description with a summary list of specific things that changed or were added. |
| @@ -0,0 +1,186 @@ | |||
| // Copyright CERN and copyright holders of ALICE O2. This software is | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nzardosh, to make sure I understand the goal of this HFConfigurables.h. This .h will contain all the default parameters of the preselection cuts, which were previously set directly inside the task. They will be overwritten if a proper JSON file is given to the task. Do I understand it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes indeed this is correct
|
|
||
| double getPtD0Min() const | ||
| { | ||
| return mPtD0Min; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is allowed in such cases to make the variables themselves public and skip the getters...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i have changed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgrosseo out of interest if I try to access these in the struct but outside the process function, would it be possible without the getters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be JpsiToEEFlag, jpsiToEEFlag to be consistent with the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing, I will change it
6d0972d to
c6324b7
Compare
further chnages for PreSel adding final touches adding histograms correct vertex reconstruction adding Jpsitoee adding debug option mend
further chnages for PreSel
adding final touches
adding histograms
correct vertex reconstruction
adding Jpsitoee