Skip to content

Do not propagate to refX in TPC refitter when not not needed #13087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Apr 28, 2024
Merged

Do not propagate to refX in TPC refitter when not not needed #13087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Detectors/GlobalTracking/src/MatchCosmics.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ void MatchCosmics::refitWinners(const o2::globaltracking::RecoContainer& data)
mTPCCorrMapsHelper, mBz,
tpcClusRefs.data(), 0, tpcClusShMap.data(),
tpcClusOccMap.data(), tpcClusOccMap.size(), nullptr, o2::base::Propagator::Instance());
tpcRefitter->setTrackReferenceX(900); // disable propagation after refit by setting reference to value > 500
}

const auto& itsClusters = prepareITSClusters(data);
Expand Down
2 changes: 1 addition & 1 deletion Detectors/GlobalTracking/src/MatchTOF.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,7 +1805,7 @@ bool MatchTOF::makeConstrainedTPCTrack(int matchedID, o2::dataformats::TrackTPCT
if (mTPCClusterIdxStruct) { // refit was requested
float chi2 = 0;
mTPCRefitter->setTrackReferenceX(o2::constants::geom::XTPCInnerRef);
if (mTPCRefitter->RefitTrackAsTrackParCov(trConstr, tpcTrOrig.getClusterRef(), timeTOFTB, &chi2, false, true) < 0) { // outward refit after resetting cov.mat.
if (mTPCRefitter->RefitTrackAsTrackParCov(trConstr, tpcTrOrig.getClusterRef(), timeTOFTB, &chi2, false, true) < 0) { // inward refit after resetting cov.mat.
LOGP(debug, "Inward Refit failed {}", trConstr.asString());
return false;
}
Expand Down
1 change: 1 addition & 0 deletions Detectors/GlobalTracking/src/MatchTPCITS.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ bool MatchTPCITS::prepareTPCData()
}
*/
mTPCRefitter = std::make_unique<o2::gpu::GPUO2InterfaceRefit>(mTPCClusterIdxStruct, mTPCCorrMapsHelper, mBz, mTPCTrackClusIdx.data(), 0, mTPCRefitterShMap.data(), mTPCRefitterOccMap.data(), mTPCRefitterOccMap.size(), nullptr, o2::base::Propagator::Instance());
mTPCRefitter->setTrackReferenceX(900); // disable propagation after refit by setting reference to value > 500
mNTPCOccBinLength = mTPCRefitter->getParam()->rec.tpc.occupancyMapTimeBins;
mTBinClOcc.clear();
if (mNTPCOccBinLength > 1 && mTPCRefitterOccMap.size()) {
Expand Down
2 changes: 1 addition & 1 deletion Detectors/GlobalTrackingWorkflow/study/src/TPCTrackStudy.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ void TPCTrackStudySpec::process(o2::globaltracking::RecoContainer& recoData)
}

mTPCRefitter = std::make_unique<o2::gpu::GPUO2InterfaceRefit>(mTPCClusterIdxStruct, &mTPCCorrMapsLoader, prop->getNominalBz(), mTPCTrackClusIdx.data(), 0, mTPCRefitterShMap.data(), mTPCRefitterOccMap.data(), mTPCRefitterOccMap.size(), nullptr, o2::base::Propagator::Instance());

mTPCRefitter->setTrackReferenceX(900); // disable propagation after refit by setting reference to value > 500
float vdriftTB = mTPCVDriftHelper.getVDriftObject().getVDrift() * o2::tpc::ParameterElectronics::Instance().ZbinWidth; // VDrift expressed in cm/TimeBin
float tpcTBBias = mTPCVDriftHelper.getVDriftObject().getTimeOffset() / (8 * o2::constants::lhc::LHCBunchSpacingMUS);
std::vector<short> clSector, clRow;
Expand Down
1 change: 1 addition & 0 deletions Detectors/TPC/workflow/src/TPCRefitter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ void TPCRefitterSpec::process(o2::globaltracking::RecoContainer& recoData)
}

mTPCRefitter = std::make_unique<o2::gpu::GPUO2InterfaceRefit>(mTPCClusterIdxStruct, &mTPCCorrMapsLoader, prop->getNominalBz(), mTPCTrackClusIdx.data(), 0, mTPCRefitterShMap.data(), mTPCRefitterOccMap.data(), mTPCRefitterOccMap.size(), nullptr, prop);
mTPCRefitter->setTrackReferenceX(900); // disable propagation after refit by setting reference to value > 500

float vdriftTB = mTPCVDriftHelper.getVDriftObject().getVDrift() * o2::tpc::ParameterElectronics::Instance().ZbinWidth; // VDrift expressed in cm/TimeBin
float tpcTBBias = mTPCVDriftHelper.getVDriftObject().getTimeOffset() / (8 * o2::constants::lhc::LHCBunchSpacingMUS);
Expand Down
1 change: 1 addition & 0 deletions Detectors/TRD/workflow/src/TRDGlobalTrackingSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ void TRDGlobalTracking::run(ProcessingContext& pc)

mTPCClusterIdxStruct = &inputTracks.inputsTPCclusters->clusterIndex;
mTPCRefitter = std::make_unique<o2::gpu::GPUO2InterfaceRefit>(mTPCClusterIdxStruct, &mTPCCorrMapsLoader, o2::base::Propagator::Instance()->getNominalBz(), inputTracks.getTPCTracksClusterRefs().data(), 0, inputTracks.clusterShMapTPC.data(), inputTracks.occupancyMapTPC.data(), inputTracks.occupancyMapTPC.size(), nullptr, o2::base::Propagator::Instance());
mTPCRefitter->setTrackReferenceX(900); // disable propagation after refit by setting reference to value > 500
auto tmpInputContainer = getRecoInputContainer(pc, &mChainTracking->mIOPtrs, &inputTracks, mUseMC);
auto tmpContainer = GPUWorkflowHelper::fillIOPtr(mChainTracking->mIOPtrs, inputTracks, mUseMC, nullptr, GTrackID::getSourcesMask("TRD"), mTrkMask, GTrackID::mask_t{GTrackID::MASK_NONE});
mTrackletsRaw = inputTracks.getTRDTracklets();
Expand Down
1 change: 1 addition & 0 deletions Detectors/Vertexing/src/SVertexer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ void SVertexer::buildT2V(const o2::globaltracking::RecoContainer& recoData) // a
mTPCRefitterShMap = recoData.clusterShMapTPC;
mTPCRefitterOccMap = mRecoCont->occupancyMapTPC;
mTPCRefitter = std::make_unique<o2::gpu::GPUO2InterfaceRefit>(mTPCClusterIdxStruct, mTPCCorrMapsHelper, o2::base::Propagator::Instance()->getNominalBz(), mTPCTrackClusIdx.data(), 0, mTPCRefitterShMap.data(), mTPCRefitterOccMap.data(), mTPCRefitterOccMap.size(), nullptr, o2::base::Propagator::Instance());
mTPCRefitter->setTrackReferenceX(900); // disable propagation after refit by setting reference to value > 500
}

std::unordered_map<GIndex, std::pair<int, int>> tmap;
Expand Down