Message: Fix duplicates in the reply stack #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenskoy
reviewed
Dec 12, 2023
| const replyStack = selectReplyStack(global, chatId, threadId, tabId) || []; | ||
| global = replaceTabThreadParam(global, chatId, threadId, 'replyStack', [...replyStack, replyMessageId], tabId); | ||
|
|
||
| if (replyMessageId !== replyStack[replyStack.length - 1]) { |
Contributor
There was a problem hiding this comment.
What happens if replyStack is an empty array?
Author
There was a problem hiding this comment.
In this case, the condition will not be satisfied because replyStack[-1] equals undefined, and this does not cause any errors to be thrown.
Contributor
There was a problem hiding this comment.
Clicking between several replies adds them to the reply stack without any limits
korenskoy
approved these changes
Dec 18, 2023
Contributor
korenskoy
left a comment
There was a problem hiding this comment.
Thank you!
Please update the pr title to "Message: Fix duplicates in the reply stack"
f1a656a to
396e6e0
Compare
👷 Deploy request for telegram-tt-previews pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #305