Skip to content

Vuex Devtools plugins registered on server which increases memory usage #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
urbnjamesmi1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Vuex Devtools plugins registered on server which increases memory usage #2251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes #2250 
- Add check that code is running in a browser before adding devtools
  • Loading branch information
@urbnjamesmi1
urbnjamesmi1 committed Jul 15, 2024
commit e06ad55eb2d20133b7c8cbedd764b30bcbd04ad0
6 changes: 4 additions & 2 deletions src/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {
unifyObjectStyle
} from './store-util'

const isBrowser = typeof document !== 'undefined'

export function createStore (options) {
return new Store(options)
}
Expand Down Expand Up @@ -73,9 +75,9 @@ export class Store {
app.provide(injectKey || storeKey, this)
app.config.globalProperties.$store = this

const useDevtools = this._devtools !== undefined
const useDevtools = (this._devtools !== undefined
? this._devtools
: __DEV__ || __VUE_PROD_DEVTOOLS__
: __DEV__ || __VUE_PROD_DEVTOOLS__) && isBrowser

if (useDevtools) {
addDevtools(app, this)
Expand Down