Skip to content

Conversation

@keradus
Copy link
Member

@keradus keradus commented Dec 16, 2025

Q A
Branch? 8.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix CS
License MIT

inspired by https://github.com/symfony/symfony/pull/62762/changes#r2622285457

DRAFT, as not applied to whole repo, only to one bridge to show example outpuut.
if you like the change, i can apply to whole repo

I suggest to see what will fail, revert such package, merge the rest.
then, handle other packages in separated PRs

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, one less thing to be patched randomly :)

nicolas-grekas added a commit that referenced this pull request Dec 17, 2025
This PR was submitted for the 7.4 branch but it was merged into the 7.3 branch instead.

Discussion
----------

[JsonPath] fix calling non-static method statically

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes-ish
| New feature?  | no <!-- if yes, also update src/**/CHANGELOG.md -->
| Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Issues        | Fix compiler complaints
| License       | MIT

if [lambda would be declared as static](#62783), calling non-static method from it would fail with the following error:
> Error: Non-static method Symfony\Component\JsonPath\JsonCrawler::normalizeStorage() cannot be called statically

let's not call non-static method statically.

Commits
-------

22db41e src/Symfony/Component/JsonPath - fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants