Qt: Request a specific GL version so GLES doesn't get used on Wayland. #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this "QT_QPA_PLATFORM=xcb" is needed on Wayland or else the shaders may not compile.
Member
|
@WickedSmoke This is fine, I'll merge it. But I thought the GTK version was using GLES because back then they mistakenly thought Wayland apps needed to use it (they don't). Maybe it just needed to be specified like in this patch? Edit: Also, I'm running on Wayland (gnome) and it works either way. At some point I'll uninstall XWayland to be sure things can't quietly fall back to that. |
Contributor
Author
|
I don't see anywhere in guigtk.cpp where a version is specified. The header in rendergl3.cpp says it's for "OpenGL 3.0", but in a comment later it says "core OpenGL 3 profile". Profiles were added in 3.2, so all the platforms should be requesting the 3.2 core profile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this "QT_QPA_PLATFORM=xcb" is needed on Wayland or else the shaders may not compile.
Fixes issue #1650.