Allow turntable to use Y axis. #1504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5e71a8 to
a3055bc
Compare
Contributor
Author
|
I see many years ago @vespakoen tried to implement this in commit 97630bd. |
Member
|
Checkboxes and radio buttons work exactly the same way. Here is an example: solvespace/src/textscreens.cpp Line 419 in 30e42ca We just added the checkbox for "skewed" extrusions, but it's functionally identical to the radio buttons - just looks different. |
Contributor
Author
|
Yeah, I saw the addition of "skewed" but I couldn't understand how to use that feature. A proper combo widget would be more future proof as any number of rotation options could be added without taking up more screen space. |
Turntable was added in commit e67f967.
ce62ea4 to
0cca194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As normal math conventions and OpenGL have the Y axis pointing up I would like an option to have turntable rotation use this axis.
This code currently just changes Z up to Y up. What would be the best way to add an option to the UI? Another checkbox would be easiest to implement, but a combo of (Free, Turntable Y, Turntable Z) would be less controls for the user to futz with. Is there combo box support with the current UI?