Skip to content

C# sample project #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TrevorDArcyEvans wants to merge 7 commits into
base: master
Choose a base branch
from
Open

C# sample project #1248

TrevorDArcyEvans wants to merge 7 commits into from

Conversation

@TrevorDArcyEvans
Copy link

@TrevorDArcyEvans TrevorDArcyEvans commented May 24, 2022

  • conversion of VB.NET sample to C#
  • factored out SolveSpace functionality to a separate file & namespace
  • C# project

@phkahler phkahler requested a review from ruevs May 24, 2022 14:24
@phkahler
Copy link
Member

phkahler commented May 24, 2022

Does this actually work? I never noticed the VB.NET one but C# seems like an even better idea.

@TrevorDArcyEvans
Copy link
Author

TrevorDArcyEvans commented May 24, 2022

@phkahler Does it work? LOL! It definitely works ie outputs something to console and doesn't crash.

ruevs
ruevs reviewed May 25, 2022
View reviewed changes
exposed/CsDemo/.gitignore
@@ -0,0 +1,369 @@
## Ignore Visual Studio temporary files, build results, and
Copy link
Member

@ruevs ruevs May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding such a huge .gitignore seems like bad form to me. One that ignores only the specific files and directories created by VS when building the example is (in my opinion) better. Currently I do not have the C# build tools in my VS installation but I will add them (when I get to my development system) and try the example.

Copy link
Author

@TrevorDArcyEvans TrevorDArcyEvans May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a 'standard' .gitignore from here

Copy link
Member

@ruevs ruevs May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is clear from the comment at the top.

@vespakoen
Copy link
Contributor

vespakoen commented Dec 9, 2024 •
edited
Loading

Please take a look at the new C library, especially ExampleStateful in CDemo.c, it looks similar to what you are doing in the Solver.cs wrapper, and perhaps by leveraging the new C lib you can make your wrapper code simpler.

Also you might want to use LibraryImport over DllImport in C#.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruevs ruevs ruevs left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrevorDArcyEvans @phkahler @vespakoen @ruevs