Skip to content

[fix] only show and clear known cookies #4149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
GenericMale wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[fix] only show and clear known cookies #4149

GenericMale wants to merge 1 commit into from

Conversation

@GenericMale
Copy link

@GenericMale GenericMale commented Dec 29, 2024

What does this PR do?

This PR modifies the clear_cookies function to now only delete cookies related to user preferences. It also adjusts the cookie display logic to only show these relevant preference cookies. This ensures that session cookies and other non-preference cookies are preserved, preventing unintended side effects (see #3763).

Why is this change important?

Previously, the clear_cookies function was deleting all cookies, including cookies from other services on the same domain, session cookies etc.

How to test this PR locally?

  1. Navigate to the preferences page.
  2. Set and save some user preferences.
  3. Navigate to the cookies tab.
  4. Verify all searxng cookies are shown but no other cookies. Foreign cookies can be simulated using Javascript, e.g. document.cookie = "username=John Doe" in the Browser console
  5. Click the "Reset defaults" button.
  6. Verify all searxng cookies are deleted but other cookies are preserved.

Related issues

Closes #3763

@return42
Copy link
Member

return42 commented Jan 6, 2025 •
edited
Loading

I still hesitate to merge this PR since I have a few doubts:

Name collisions with other apps on the same domain are not solved (e.g. language and theme are very common) and problematic code mentioned by @glanham-jr in #3763 (comment) is not addressed -> I think the preference code needs a complete review .. meanings?

@GenericMale
Copy link
Author

GenericMale commented Jan 6, 2025

I still hesitate to merge this PR since I have a few doubts:

Name collisions with other apps on the same domain are not solved (e.g. language and theme are very common) and problematic code mentioned by @glanham-jr in #3763 (comment) is not addressed -> I think the preference code needs a complete review .. meanings?

hasn't the mentioned "problematic" code been removed in #3966 or is this something else?

in my opinion the very generic names of the cookies used by SearXNG is a related but different issue which will obviously require a lot more work (and some sort of migration) than this small improvement which (hopefully) has minimal impact but ensures SearXNG will not touch any cookies it doesn't know about at all (which imho is required in any case).

glanham-jr
glanham-jr reviewed Jan 10, 2025
View reviewed changes
@return42 return42 mentioned this pull request Feb 7, 2025
Closed
@return42 return42 marked this pull request as draft February 28, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glanham-jr glanham-jr glanham-jr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preferences show and overwrite unknown cookies

3 participants

@GenericMale @return42 @glanham-jr