[feat] allow customization of logo and favicon #4101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removed searxng-wordmark from templates directory and build files, because it is no longer used anywhere
Member
Member
|
update: please read this comment TBH I have lost sight of #2276 .. I'm very sorry .. and thanks for reminding me 👍 I prefer the way #3208 goes, adding |
Member
|
In contrast to #2276 I personally prefer this PR here because it allows to set The specific way of implementation here however is debatable, I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows for an instance administrator to configure a custom logo and favicon in settings.yml
Why is this change important?
This feature has been requested in #3208, and based on the number of thumbs up emojis, is wanted by several people (although I guess it's not that important)
How to test this PR locally?
Set the custom_files.* options in settings.yml
Related issues
Closes #3208
Sorry if there are a lot of issues with this, it's my first ever PR :)