ENH add clearer error message when instance is passed instead of class #32888
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line, FeatureUnion and ColumnTransformer
Contributor
Author
|
I suppose the changelog is not checked because it is not in one of the labelled modules? |
Member
The changelog fails because the action also checks the correct naming of the file. Fizzy thing, but instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #32719
What does this implement/fix? Explain your changes.
It adds a simple check to
Pipeline,FeatureUnionandColumnTransformerto raise a clearer error message if the user accidentally passed a class instead of an instance, and provides corresponding non-regression test.AI usage disclosure
I used AI assistance for:
Any other comments?
As noted in my comment here, it could also be added to the existing
_validate_estimator()function in_BaseHeterogeneousEnsembleand its version inStackingClassifierin a follow-up PR. If I followed the class hierarchy correctly, then this would also catch this mistake inStackingClassifier,StackingRegressor,VotingClassifierandVotingRegressor. I didn't check the other meta-estimators yet.