FIX: Tooltip position using CSS anchor positioning #32887
Merged
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Dec 12, 2025
| ) | ||
| html_output = _params_html_repr(params) | ||
|
|
||
| print(html_output) |
Member
There was a problem hiding this comment.
This is some remaining debugging I think.
Member
|
I think that you can add an entry in the changelog for the |
glemaitre
approved these changes
Dec 12, 2025
Member
glemaitre
left a comment
There was a problem hiding this comment.
Otherwise, it is an improvement. LGTM.
thomasjpfan
reviewed
Dec 13, 2025
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Looking at the anchor-name support table it is not supported in Firefox yet.
With this change, what does the tooltip look like in Firefox?
Member
Author
Thanks for asking, because I forgot to check. With the latest commit, the tooltip looks in Firefox like in the other browsers before this fix. (I added @supports`) |
thomasjpfan
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
The documentation tooltip that we introduced with #31564 is hidden if the parameter name that it belongs to, is at the bottom of the table. It's visible only after scrolling down the cell.
In this case, when we hover over
n_jobs, we get:Using CSS anchor positioning:, the result is the following (when hovering over
n_jobs). No scroll-down needed:There is no opened issue for this.
What does this implement/fix? Explain your changes.
For the record: The specs for
anchor-nameandposition-anchorcan't be placed in theparams.cssfile. When I did that, the tooltip was always visible at the bottom of the table - not next to the parameter name.(It was @glemaitre's idea that the tooltip was getting fixed to the last parameter when using Chrome.)
AI usage disclosure
I used AI assistance for:
params.pyinstead of keeping it onparams.css.Any other comments?
I tried to set Fallback options
but I haven't found the correct rule.Edit: I think the UX would be annoying if I add the fallback options.