Add an integration test for the use of array API in a non-trivial pipeline #32873
+358
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
commented
Dec 11, 2025
| ( | ||
| RidgeClassifier(), | ||
| 3, | ||
| ["accuracy"], |
Member
Author
There was a problem hiding this comment.
I would like to add "roc_auc" or "average_precision" here, but they do not yet support array API at this time: #26024.
Member
Author
lucyleeow
reviewed
Dec 12, 2025
Comment on lines
+227
to
+231
| # Ensure that all inputs are on the y_pred device and namespace. | ||
| y_true = move_to(y_true, xp=xp, device=device) | ||
| sample_weight = move_to(sample_weight, xp=xp, device=device) | ||
| if hasattr(multioutput, "shape"): | ||
| multioutput = move_to(multioutput, xp=xp, device=device) |
Member
There was a problem hiding this comment.
Why not just leave this to _check_reg_targets to handle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this kind of test would have help identify some of the problem discovered during the release process earlier.
Note that it still fails because
RidgeandLinearDiscriminantAnalysisstill do not accept mixed-array inputs (see #28668).Not sure if we should fix that here or in a PR that introduces a common test for that particular problem.
EDIT: I started to push a fix for the regression case to investigate all the possibly cascading bugs to fix (hiding one after the other). For the regression case we need both #28668 and #32755 and this is enough.
For classification, it seems that there is extra work needed in the private scorer code on top of updating the classifier and the metrics functions themselves.