Skip to content

Conversation

@virchan
Copy link
Member

@virchan virchan commented Dec 8, 2025

Reference Issues/PRs

A follow-up to #31068 and #32809 (comment)

What does this implement/fix? Explain your changes.

This PR adds an example demonstrating the use of temperature scaling for multi-class probability calibration.

Any other comments?

Cc @lorentzenchr for visibility

@virchan virchan marked this pull request as ready for review December 8, 2025 03:53
@lorentzenchr
Copy link
Member

Given that we already have so many examples, see #27151, I‘d prefer to have this here integrated into an existing one.

@virchan
Copy link
Member Author

virchan commented Dec 8, 2025

I'll convert this back to draft and work on it.

@virchan virchan marked this pull request as draft December 8, 2025 06:36
@virchan virchan marked this pull request as ready for review December 12, 2025 06:34
Copy link
Member Author

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to review! Since plot_calibration_curve.py now covers multi-class classification, we can probably remove plot_calibration_multiclass.py.

@lorentzenchr, would you like to have a look?

@lorentzenchr
Copy link
Member

Thanks for putting in an existing example. I am a bit undecided between the one you chose "Probability Calibration curves"/plot_calibration_curve.py and "Probability Calibration for 3-class classification"/plot_calibration_multiclass.py.
What do other maintainers think, e.g. @lucyleeow, @OmarManzoor @ogrisel?

@ogrisel
Copy link
Member

ogrisel commented Dec 12, 2025

I agree: i think we should keep this particular example about calibration of binary classifiers because a lot of the text in the analysis that was correct for binary classification (eg monotonicity and area under the roc curve) does not carry over directly to the multiclass setting.

@virchan virchan marked this pull request as draft December 12, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants