FIX: Fixed duplicate column error appearing with FeatureUnion polars #32853
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Dec 8, 2025
Member
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the fix. It looks correct to me but I think the testing of pandas and polars should be decoupled:
sklearn/tests/test_pipeline.py
Outdated
| assert_array_equal(X_trans.columns, union.get_feature_names_out()) | ||
| assert_array_equal(X_trans.index, X_test.index) | ||
|
|
||
| # Test with polars |
Member
There was a problem hiding this comment.
I would rather use @pytest.mark.parametrize(df_library, ["pandas", "polars"]) so that the full test is not marked as skipped if only one of the two libs is installed.
Author
There was a problem hiding this comment.
Thanks for the feedback, very valid point, fixed it in the new commit.
… ensure the whole test is not skipped if only one of the dependencies is installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using FeatureUnion with set_config(transform_output="polars"), the operation failed with polars.exceptions.DuplicateError because the ContainerAdapterProtocol.hstack() interface was incomplete: it didn't accept a
feature_namesparameter to apply column renaming before concatenation.Fixes #32852