DOC: Update the description of RandomState usage to match actual behaviour #32844
+52
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to the ongoing discussion on managing RandomState objects : #26148
What does this implement/fix? Explain your changes.
The documentation's description of what happens when cloning an estimator initialized with a
RandomStateinstance was not reflecting the current behaviour, stating theRandomStateobject is shared between clones while it is actually deepcopied. I updated this description to match the current behaviour, updating also the recommendations for CV and adding a warning to indicate that this is not the intended behaviour and it is worked on by maintainers.AI usage disclosure
I used AI assistance for:
Any other comments?