-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
CI: Make one tracking isssue per build for the unit-tests GHA #32832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FrancoisPgm
wants to merge
28
commits into
scikit-learn:main
Choose a base branch
from
FrancoisPgm:one_issue_per_build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses this comment : #32797 (comment)
What does this implement/fix? Explain your changes.
Instead of opening a single issue if any of the tests in the matrix failed, now independent issues for each matrix entry are generated.
Also allow the update tracking issue action to trigger on manually triggered actions.
AI usage disclosure
I used AI assistance for:
Any other comments?
It is a bit more complex to achieve than what I anticipated. I could not do it using a job running after all the matrix jobs of unit-tests, as github does not allow to access all outptuts of a matrix of jobs, so only a global status of the whole matrix ("success" if all jobs succeeded, "failure" if at least one failed) can be obtained in another job.
Thus I had to use an extra step in the unit-tests job, but using another workflow (i.e.
uses: ./.github/workflows/update_tracking_issue.yml) cannot be done as a step, only as a job, so I had to re-implement it, creating some code duplication. But it also allowed to tweak the CI log URL to point to the log of the specific job rather than the whole workflow. And since github does not expose the job id necessary for this URL, I also had to add a step to get this id using the REST API.I tested it on my fork, for example it created and commented FrancoisPgm#23