Skip to content

Conversation

@Sarthak070606
Copy link

This pull request fixes two minor documentation formatting issues in _logistic.py:

  • Added missing spaces in the tuple {'l2','none'}{'l2', 'none'}.
  • Fixed spacing in the l1_ratio condition 0 <l1_ratio <10 < l1_ratio < 1.

These changes improve readability and maintain consistency with the scikit-learn
documentation style guide.

No functional code changes.

@github-actions
Copy link

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here


ruff check

ruff detected issues. Please run ruff check --fix --output-format=full locally, fix the remaining issues, and push the changes. Here you can see the detected issues. Note that the installed ruff version is ruff=0.11.7.


sklearn/linear_model/_logistic.py:221:1: W293 Blank line contains whitespace
    |
219 |     to using ``penalty='l1'``. For ``0 < l1_ratio < 1``, the penalty is a
220 |     combination of L1 and L2.
221 |     
    | ^^^^ W293
222 |     n_threads : int, default=1
223 |        Number of OpenMP threads to use.
    |
    = help: Remove whitespace from blank line

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

Generated for commit: 952ce2c. Link to the linter CI: here

@github-actions github-actions bot added the CI:Linter failure The linter CI is failing on this PR label Nov 29, 2025
@Sarthak070606
Copy link
Author

Hi! 👋
Added missing spaces in the tuple {'l2','none'} → {'l2', 'none'}.
Fixed spacing in the l1_ratio condition 0 <l1_ratio <1 → 0 < l1_ratio < 1.
This is my contribution to scikit-learn.
If there’s anything I should improve or adjust, please let me know — I’m happy to make changes. 😊

Thanks for your time and review!

@lucyleeow lucyleeow added the autoclose PR automatically closed 14 days after setting the label label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to scikit-learn and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity needed for an effective review. Reviewing time is limited, and our goal is to prioritize well-prepared contributions to keep scikit-learn maintainable. Unless this PR is improved, it will be automatically closed after two weeks.

To avoid autoclose and increase the chance of a productive review, please:

  • Ensure your contribution aligns with our contribution guide.
  • Include a clear motivation and concise explanation in the pull request description of why you chose this solution.
  • Make sure the code runs and passes tests locally (pytest) and in the CI.
  • Submit only code you can explain and maintain; reviewers will ask for clarifications and changes. Disclose any AI assistance per our Automated Contributions Policy.
  • Keep the changes minimal and directly relevant to the described issue or enhancement.

We cannot provide one-to-one guidance on every PR, though we encourage you to ask focused, actionable questions that show you have tried to explore the problem and are interested to engage with the project. 💬 Sometimes a maintainer or someone else from the community might be able to offer pointers.

If you improve your PR within the two-week window, the autoclose label can be removed by maintainers.

@github-actions
Copy link

Thank you for your interest in contributing to scikit-learn, but we cannot accept your contribution as this pull request does not meet our development standards.

Following our autoclose policy, we are closing this PR after allowing two weeks time for improvements.

Thank you for your understanding. If you think your PR has been closed by mistake, please comment below.

@github-actions github-actions bot closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose PR automatically closed 14 days after setting the label CI:Linter failure The linter CI is failing on this PR Documentation module:linear_model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants