Rework FFT Ops #282
Merged
Rework FFT Ops #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `out = ops.op("filter.fft").arity1().input(img).apply()` returns
a blank image. This is because the wrong image dimensions are being used
for the FFT result. This is an example of when adaptation fails. SciJava
Ops adapts the FFT Op into a function and assumes that the output image
dimensions are the same as the input. Generally this is a safe
assumption, but this is an example where the output image dimensions
are in fact different. This commit adds a new Op that depends on
`FFTMethodsOpF` and returns the FFT result as a ComplexFloatType. This
is consistent with the old imagej-ops usage.
This commit throws all of them, rewritten as static methods, into one class, and adds a test to ensure proper matching of function FFT Ops
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/60 |
ctrueden
approved these changes
Feb 11, 2025
Member
ctrueden
left a comment
There was a problem hiding this comment.
Awesome! Thank you for following through on this improvement. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a modified version of work that @elevans started to improve FFT operations written as Functions. It now enables (and tests) that the following Op call works:
The main modification I added on top was extracting all of the FFT Ops into a single
FFT.javaclass, rewriting them as static methods in the process. This obviates the many miscellaneous, ambiguously-named files in the package.