Fix pip.installed state managed pre-release upgrades #68526
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16ddd3a to
2a05161
Compare
Author
|
I've been able to trace the bug back to the inception of the code that uses pip index versions, so I based the PR on the v3004.x branch, but I'm unsure if that was the appropriate one. I'm also having a bit of trouble with the tests, but I didn't want it to block the contribution. |
Contributor
|
We do bug fixes on the olders supported branch where the bug exists. There will be no more releases of 3004 and 3005. The oldest supported branch is 3006.x. Please rebase this PR on 3006.x. |
`pip index versions` will never yield pre-release versions of the package without the `--pre` option. In effect, this means providing `pre_releases=True` and `upgrade=True` to the `pip.installed` state will never work, but I'm unsure of the actual extent of this bug.
2a05161 to
7a239d1
Compare
Author
|
Rebased to 3006.x and refactored the test a bit to utililze the new fixtures and provide more coverage. |
6213954 to
2af6443
Compare
twangboy
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes #68525
Previous Behavior
Python packages installed in an environment would not upgrade to their pre-release version when any exist in the index.
New Behavior
Pre-release versions of packages managed by
pip.installedstate are upgraded when usingupgrade=Trueandpre_releases=True.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No