Parody thin functionality for relenv and salt-ssh #68520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses test failures and improves salt-ssh relenv/thin parity: 1. Update grains state unit test expectations to match new "(or pending)" message format introduced in previous commits 2. Add "wrapper" and "tops" to sync_refs in mod_data() to ensure these extension module types are synced to SSH minions in ext_mods.tgz. This fixes integration test failures where wrapper modules weren't being deployed, ensuring relenv approach has feature parity with thin. Fixes: - tests/pytests/unit/states/test_grains.py::test_list_present_already - tests/pytests/unit/states/test_grains.py::test_list_present_nested_already - tests/pytests/integration/ssh/test_deploy.py::test_wrapper_unwrapped_command_exception - tests/pytests/integration/ssh/test_deploy.py::test_wrapper_unwrapped_command_parsing_failure - tests/pytests/integration/ssh/test_deploy.py::test_wrapper_unwrapped_command_invalid_return - tests/pytests/integration/ssh/test_jinja_mods.py::test_wrapper_attribute_access - tests/pytests/integration/ssh/test_master.py::test_custom_wrapper - tests/pytests/integration/ssh/test_state.py::test_state_show_top - tests/pytests/integration/ssh/test_state.py::test_state_running
1d7ee97 to
98e144b
Compare
This change is not related to the ssh relenv work on our current branch and was added by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize our ssh tests to run with thin and relenv fixing anything that doesn't work for relenv along the way.
#68531