Skip to content

Conversation

@ironman627
Copy link
Contributor

What does this PR do?

Add archive.compressed function to state module

What issues does this PR fix or reference?

Fixes #67243

Previous Behavior

Archive.extracted was the only function available in the state module

New Behavior

archive.compressed - added function to zip files and directories into compressed files for backup, transfer, etc.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@ironman627 ironman627 requested a review from a team as a code owner December 1, 2025 19:34
@welcome
Copy link

welcome bot commented Dec 1, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We're glad you've joined our community and look forward to doing awesome things with you!

Comment on lines -260 to -266
signature=None,
source_hash_sig=None,
signed_by_any=None,
signed_by_all=None,
keyring=None,
gnupghome=None,
sig_backend="gpg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these parameters removed? These should not be removed.

@bdrx312
Copy link
Contributor

bdrx312 commented Dec 2, 2025

This PR states it fixes #67243 but 67243 appears to be requesting the extracted function to support extracting gzipped archives--not creating gzipped archives. I am pretty sure archive.extracted state already supports gzip now and 67243 can be closed without this PR.

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the template and testing guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants