-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add archive.compressed function to state module #68498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
| signature=None, | ||
| source_hash_sig=None, | ||
| signed_by_any=None, | ||
| signed_by_all=None, | ||
| keyring=None, | ||
| gnupghome=None, | ||
| sig_backend="gpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these parameters removed? These should not be removed.
|
This PR states it fixes #67243 but 67243 appears to be requesting the extracted function to support extracting gzipped archives--not creating gzipped archives. I am pretty sure archive.extracted state already supports gzip now and 67243 can be closed without this PR. |
twangboy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the template and testing guide
What does this PR do?
Add archive.compressed function to state module
What issues does this PR fix or reference?
Fixes #67243
Previous Behavior
Archive.extracted was the only function available in the state module
New Behavior
archive.compressed - added function to zip files and directories into compressed files for backup, transfer, etc.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No