Skip to content

Stop using fixed test directory names #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehuelsmann merged 1 commit into from
Nov 14, 2025
Merged

Stop using fixed test directory names #275

ehuelsmann merged 1 commit into from
Nov 14, 2025

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Nov 14, 2025

Description

Fixes concurrent tests trampling on each other.

Type of change

Please delete options that are not relevant.

  • Bug fix in test suite (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ehuelsmann
Stop using fixed test directory names
a7c0d9d 
This fixes concurrent tests trampling on each other.
@ehuelsmann ehuelsmann requested a review from jonasbn November 14, 2025 12:43
@coveralls
Copy link

coveralls commented Nov 14, 2025

Pull Request Test Coverage Report for Build 19364955253

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.215%
Totals Coverage Status
Change from base Build 19364064667: 0.0%
Covered Lines: 1374
Relevant Lines: 1490
💛 - Coveralls

jonasbn
jonasbn reviewed Nov 14, 2025
View reviewed changes
jonasbn
jonasbn reviewed Nov 14, 2025
View reviewed changes
jonasbn
jonasbn requested changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ehuelsmann

Please see my questions, else I regard this as approved

@jonasbn
Copy link
Collaborator

jonasbn commented Nov 14, 2025

@ehuelsmann I need to read the documentation, it just struck me that the Xs have a meaning

@ehuelsmann
Copy link
Member Author

ehuelsmann commented Nov 14, 2025 •
edited
Loading

I looked at the documentation: https://metacpan.org/pod/File::Temp#:~:text=template%29%3B-,Create,the%20template

which says:

Create a temporary file in the current directory using the supplied template. Trailing 'X' characters are replaced with random letters to generate the filename. At least four 'X' characters must be present at the end of the template.

@ehuelsmann ehuelsmann requested a review from jonasbn November 14, 2025 16:54
jonasbn
jonasbn approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ehuelsmann

This is approved :-)

Thanks for the clarification, I was just about to look it up

@jonasbn jonasbn added this to the 2.09 milestone Nov 14, 2025
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Nov 14, 2025
@ehuelsmann ehuelsmann merged commit 31bda23 into perl-workflow:master Nov 14, 2025
7 checks passed
@ehuelsmann ehuelsmann deleted the fix-concurrent-testing branch November 14, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

maintenance Maintenance of tools and configuration

Projects

None yet

Milestone

2.09

Development

Successfully merging this pull request may close these issues.

3 participants

@ehuelsmann @coveralls @jonasbn