Skip to content

[GR-36894] Migrate GraalPy to DynamicObject nodes #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graalvmbot wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[GR-36894] Migrate GraalPy to DynamicObject nodes #566

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbd346f
[GR-36894] Migrate GraalPy to DynamicObject nodes
eregon Aug 25, 2025
1c039dc
Use separate read attribute nodes for different fixed keys.
woess Nov 6, 2025
b534b91
Remove unnecessary cached property assumption.
woess Nov 7, 2025
5af8c44
Update graal import.
woess Nov 7, 2025
3797418
Sync CI files.
woess Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use separate read attribute nodes for different fixed keys.
  • Loading branch information
@woess
woess committed Nov 17, 2025
commit 1c039dc2b5335551cb2801f6b1e99b0bbb93d615
6 changes: 4 additions & 2 deletions ...acle.graal.python/src/com/oracle/graal/python/builtins/objects/module/ModuleBuiltins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,8 @@ static Object getattribute(VirtualFrame frame, PythonModule self, TruffleString
@Bind Node inliningTarget,
@Cached IsBuiltinObjectProfile isAttrError,
@Cached ReadAttributeFromModuleNode readGetattr,
@Cached ReadAttributeFromModuleNode readName,
@Cached ReadAttributeFromModuleNode readSpec,
@Cached ReadAttributeFromObjectNode readInitializing,
@Cached InlinedConditionProfile customGetAttr,
@Cached CallNode callNode,
Expand All @@ -291,13 +293,13 @@ static Object getattribute(VirtualFrame frame, PythonModule self, TruffleString
} else {
TruffleString moduleName;
try {
moduleName = castNameToStringNode.execute(inliningTarget, readGetattr.execute(self, T___NAME__));
moduleName = castNameToStringNode.execute(inliningTarget, readName.execute(self, T___NAME__));
} catch (CannotCastException ce) {
// we just don't have the module name
moduleName = null;
}
if (moduleName != null) {
Object moduleSpec = readGetattr.execute(self, T___SPEC__);
Object moduleSpec = readSpec.execute(self, T___SPEC__);
if (moduleSpec != PNone.NO_VALUE) {
Object isInitializing = readInitializing.execute(moduleSpec, T__INITIALIZING);
if (isInitializing != PNone.NO_VALUE && castToBooleanNode.execute(frame, isInitializing)) {
Expand Down