-
-
Notifications
You must be signed in to change notification settings - Fork 78
Delete tables on reimport #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I had intended the third commit to be part of another pull request, but it ended up in this one... Commit 2d56c87 adds a flag to save extra data when exporting table definitions. I had an issue where field formats such as dropdown lists or checkboxes would be lost on reimport, and this fixes that issue. |
|
Dropping tables is fairly dangerous, I wonder if we should provide some kind of safety mechanism to prevent accidents |
|
I suggest adding a config to prefix the existing table, or delete it if empty. A prefix would be better than a suffix to keep the renamed tables together for easy deletion. |
|
I'd probably er on the side of crashing out hard if there's a clash, but it's probably worth canvassing the opinion of regular contributors and ideally users if we can work out how to! |
|
Hi, |
|
this does seem like a staging table scenario. You createa staging table if it succeeds delete the others and then do a rename. |
Calling "ImportAllSource" create duplicate tables (ie.: MyTable1 if MyTable already exist), and fill the original table with data. This issue was introduced on commit 2bf2b3c. This PR deletes the original table as per the old behavior.