Added text-as-path functionality to backend_ps.py for Issue #8480 #30830
+1,799
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously-committed psuedo-code
Author
|
@story645 I wanted to verify something real quick: Is the PS backend using 1,000 units per EM? Nevermind, found the UPM from the afm font files. |
to get the font size
…/matplotlib-dev into newfeature-for-issue-8480
…/matplotlib-dev into newfeature-for-issue-8480
previously-committed psuedo-code
previously-committed psuedo-code
Added pytest for new feature, rebased commits Removed trailing whitespace Implemented pytest for new feature Removed whitespace Fixed coding style Further fixed coding style Further fixed coding style. Sigh. Updated backend_ps.py to call the proper function to get the font size Rebased commits to only have one copy of the new base image
Removed trailing whitespace in backend_ps.py Properly implemented the new feature from previously-committed psuedo-code Fixed coding style Added pytest for new feature, rebased commits
Removed trailing whitespace Implemented pytest for new feature Removed whitespace Fixed coding style Further fixed coding style Further fixed coding style. Sigh. Updated backend_ps.py to call the proper function to get the font size
…/matplotlib-dev into newfeature-for-issue-8480
Author
|
@rcomer I might need some guidance on how to properly rebase my branch for a new base image. It's honestly my first time utilizing squash or rebase at all for that matter. |
Member
|
Hi @gigoiy we have instructions for interactive rebase here. Definitely make a backup copy of your branch first! https://matplotlib.org/devdocs/devel/development_workflow.html#rewrite-commit-history |
Author
|
@rcomer Definitely already made a backup copy before making this mess lol! I'll continue to tackle this on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR!!!
PR summary
Why is this change necessary?: This change is necessary so that users have the ability to save text as vector images
What problem does it solve?: The inability to not be able to save text as vector images for the PS backend restricts matplotlib's usage in scientific journals where text being embedded as an image is a requirement
What is the reasoning for this implementation?: A user opened an issue asking for this feature because it was a requirement to submit his/her/their paper to a scientific journal
Changes Made:
backend_ps.pyusing a newrcparamcalledps.pathtextrcsetup.pyto attach thevalidate_bool()validator tops.pathtextmatplotlibrcto includeps.pathtext's default valueFalsetyping.pyto includeps.pathtextbackend_ps.pyto handle math text properly when calling the new feature and fix recursivenessbackend_ps.pyto use the proper method name when callingget_size()generate_pstext.pyto help with generating the baseline imagetest_pathtext.pytopytestthe new featureSupposed to close Issue #8480
PR checklist