Move steps for updating ASF modules to Makefile #13354
Merged
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden in the GitHub workflow, it's hard to find the command to run to fix the unused imports in the generated file. Here we move this logic to a new Makefile rule, for convenient manual and automated use.
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 39m 48s ⏱️ Results for commit 67bf369. ♻️ This comment has been updated with latest results. |
alexrashed
approved these changes
Nov 10, 2025
Member
alexrashed
left a comment
There was a problem hiding this comment.
Nice! These changes are looking good, the more transparent the steps are the better! 💯
I am not fully sure if the format target fix really is tackling the root cause, but the current solution is imho semantically equivalent to the existing one, so no need to block anything here. :)
9028207 to
67bf369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hidden in the GitHub workflow, it was hard to find the command to run to fix the unused imports in the generated file, and the
pre-commitdoesn't pick this up if you run the scaffold generation manually and forget this step.Changes
Here we move the necessary commands to a single Makefile rule, for convenient manual and automated use.
(A further small commit also fixes a small issue in an existing Makefile rule, wherein a failing command wouldn't short-circuit the following command.)
Tests
make asf-regenerateworks nicely locally: the corresponding workflow would need to be run to fully test it, but it looks pretty safe to me.