Change error code from 500 to 501 in case plugin is not available in users license #13344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-a-il
reviewed
Nov 6, 2025
Comment on lines
+226
to
+233
| if ( | ||
| hasattr(exception, "reason") | ||
| and "not part of the active license agreement" | ||
| in str(getattr(exception, "reason", "")).lower() | ||
| ): | ||
| status_code = 501 | ||
| else: | ||
| status_code = 501 if config.FAIL_FAST else 500 |
Contributor
There was a problem hiding this comment.
It would be great to check if original logic is still correct, let's discuss it tomorrow 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change error code from 500 to 501 in case the plugin is not part of the active license agreement.
Eg:
localstack.aws.api.core.CommonServiceException: exception while calling cloudtrail.CreateTrail: plugin localstack.aws.provider:cloudtrail:pro is disabled, reason: This feature is not part of the active license agreementshould return 501.Changes
Set status code to
501if when creating the error response in the handler.Tests
This was tested by manually intervening the license activation process in the core repo by not updating, validating and saving the license file.
Related
Fixes FLC-97