Rework S3 url handling for internal & external clients #13120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout specified endpoint urls
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 7m 52s ⏱️ Results for commit 11ab839. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 34m 22s ⏱️ Results for commit 11ab839. |
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 56m 35s ⏱️ + 1m 56s Results for commit 11ab839. ± Comparison against base commit 17ea66b. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With #13119 we introduced a workaround for S3 presigned urls returned by Lambda.
However, this - again - showed the issues with the current URL rewriting inside internal and external clients.
The logic should not be necessary at all for internal clients (since the requests are signed and it uses path addressing), and even for external clients, it should only be necessary for the vhost s3 tests.
This PR tries removing the logic completely from internal clients, and only apply a similar logic for external clients without an explicit endpoint url override.
Changes
Testing
Testing this will require to run all community and pro pipelines, including optional ones, against this PR, to make sure we do not miss something.
To avoid regressions and give additional time for testing, this will not make it into 4.8.
TODO
What's left to do: