Skip to content

Fix the issue where on_button_cancel does not work when hovering #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tordex merged 1 commit into from
Aug 23, 2025
Merged

Fix the issue where on_button_cancel does not work when hovering #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: the issue where :hover/:active are not triggered by on_mouse_lea… 
…ve and on_button_cancel
  • Loading branch information
@NiuGuohui
NiuGuohui authored Aug 23, 2025
commit cc1314e8a2ca83fb1e0fb24694f37edb99bfb9f4
23 changes: 5 additions & 18 deletions src/document.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,9 +685,11 @@ bool document::on_mouse_leave( position::vector& redraw_boxes )
}
if(m_over_element)
{
if(m_over_element->on_mouse_leave())
auto el = m_over_element;
m_over_element = nullptr;
if(el->on_mouse_leave())
{
m_container->on_mouse_event(m_over_element, mouse_event_leave);
m_container->on_mouse_event(el, mouse_event_leave);
return m_root->find_styles_changes(redraw_boxes);
}
}
Expand Down Expand Up @@ -765,23 +767,8 @@ bool document::on_lbutton_up( pixel_t /*x*/, pixel_t /*y*/, pixel_t /*client_x*/
}

bool document::on_button_cancel(position::vector& redraw_boxes) {
if(!m_root || !m_root_render)
{
return false;
}
m_active_element = nullptr;
if(m_over_element)
{
if(m_over_element->on_mouse_leave())
{
m_container->on_mouse_event(m_over_element, mouse_event_leave);
}
if(m_over_element->on_lbutton_up(false))
{
return m_root->find_styles_changes(redraw_boxes);
}
}
return false;
return on_mouse_leave(redraw_boxes);
}

void document::get_fixed_boxes( position::vector& fixed_boxes )
Expand Down