Skip to content

fix: incorrect baseline calculation and list markers position #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tordex merged 3 commits into from
Jun 26, 2025
Merged

fix: incorrect baseline calculation and list markers position #414

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fdbdcd
fix: incorrect baseline calculation
tordex Jun 25, 2025
09d37f7
fix: incorrect position of the text of the list markers
tordex Jun 25, 2025
2db9cca
tests update for list markers and baseline fix
tordex Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: incorrect baseline calculation
  • Loading branch information
@tordex
tordex committed Jun 25, 2025
commit 9fdbdcd3f3aa9e8c75ee07f9ba4f041286cf38b5
9 changes: 8 additions & 1 deletion src/line_box.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,14 @@ std::list< std::unique_ptr<litehtml::line_box_item> > litehtml::line_box::finish
// We have inline items
top_shift = std::abs(line_max_height.top);
const int top_shift_correction = (line_height.value() - line_max_height.height()) / 2;
m_baseline = line_max_height.bottom + top_shift_correction;
// We have to calculate the baseline from the top of the line box due to possible round errors.
// The top_shift_correction is actually text offset from the top of the line box.
// The (top_shift_correction + line_max_height.height()): is the bottom of the text with shift (text_bottom).
// The line_max_height.bottom is the text baseline here.
// So the formula is:
// baseline = line_height - text_bottom + text_baseline
// The linebox baseline is the length from the bottom of the line box to the text baseline.
m_baseline = line_height.value() - (top_shift_correction + line_max_height.height()) + line_max_height.bottom;
top_shift += top_shift_correction;
if(inline_boxes_dims.count)
{
Expand Down