Skip to content

Fix: url fragment is not processed correctly #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tordex merged 6 commits into from
Jun 9, 2025
Merged

Fix: url fragment is not processed correctly #410

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd0f56f
Fix: url fragment is not processed correctly
tordex Jun 3, 2025
131b44b
refactor: hash renamed to the fragment
tordex Jun 3, 2025
4409f26
refactor: replace std::bind with lambda in litebrowser::web_page
tordex Jun 3, 2025
6795b43
refactor: removed web_page dependency from draw_buffer class
tordex Jun 3, 2025
ccf1ca8
refactor: move draw_buffer sources into own directory
tordex Jun 4, 2025
bd87c65
added url::encode an url::decode functions
tordex Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix: url fragment is not processed correctly 
Issue appears in these cases:
1. fragment contains spesial characters (quotes for example)
2. fragment starts with number
  • Loading branch information
@tordex
tordex committed Jun 3, 2025
commit bd0f56f6baa170ff5b66acbba2110d186b868960
8 changes: 2 additions & 6 deletions support/webpage/web_page.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,9 @@ void litebrowser::web_page::show_hash(const litehtml::string& hash)
m_html_host->scroll_to(0, 0);
} else
{
std::string selector = "#" + hash;
auto escaped_hash = litehtml::get_escaped_string(hash);
std::string selector = ":is([id=\"" + escaped_hash + "\"],[name=\"" + escaped_hash + "\"])";
litehtml::element::ptr el = m_html->root()->select_one(selector);
if (!el)
{
selector = "[name=" + hash + "]";
el = m_html->root()->select_one(selector);
}
if (el)
{
litehtml::position pos = el->get_placement();
Expand Down