Recording streams were failing immediately with a TypeError when cameras had recording and prebuffering enabled. The error occurred because the handleRecordingStreamRequest method was yielding empty objects instead of proper RecordingPacket structures.

Root Cause

The original implementation yielded an empty object:

async *handleRecordingStreamRequest(streamId: number): AsyncGenerator<RecordingPacket, any, any> {
  // For now, just yield an empty RecordingPacket
  yield {} as RecordingPacket
}

But HAP-nodejs expects RecordingPacket objects with this structure:

interface RecordingPacket {
  data: Buffer;
  isLast: boolean;
}

When HAP-nodejs tried to access packet.data.length, it got undefined.length causing the TypeError.

Solution

This PR fixes the issue with minimal changes:

1. Fixed updateRecordingConfiguration method signature to properly accept the recording configuration parameter as required by the HomeKit interface
2. Implemented proper handleRecordingStreamRequest that yields valid RecordingPacket objects with actual video data from the existing fragment generation pipeline
3. Added comprehensive error handling and configuration validation

The fix connects the recording stream to the existing handleFragmentsRequests method which properly generates MP4 video fragments using FFmpeg, ensuring that every packet contains valid data: Buffer and isLast: boolean properties.

Users can now successfully record video with cameras that have both recording and prebuffering enabled without encountering the TypeError.

Fixes #1505.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.