Add suppport for MQTT message matching via RegExp #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Interesting, something like this has been on my to do list for a while. I’ll take a look at your submission as soon as I can get a chance. |
9263173 to
391c115
Compare
Author
|
hmm where do I update: https://sunoo.github.io/homebridge-camera-ffmpeg/automation/mqtt.html ? |
Author
|
(updated readme and force pushed) |
Collaborator
|
That’s in a different branch of this same project: https://github.com/Sunoo/homebridge-camera-ffmpeg/blob/gh-pages/_automation/mqtt.md |
tjmehta
commented
Dec 31, 2022
| if (cameraConfig.mqtt.motionMessageRegExp) { | ||
| this.addMqttAction(cameraConfig.mqtt.motionTopic, new RegExp(cameraConfig.mqtt.motionMessageRegExp), | ||
| {accessory: accessory, active: true, doorbell: false}); | ||
| } else { |
Author
There was a problem hiding this comment.
should be backwards compatible to default to camera name
391c115 to
4cfde7d
Compare
Contributor
|
Please rebase to beta-4.1.0 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many cases when working with third-party modules where developers may not know the full MQTT message published to a particular topic. In my case, I am using nanit which broadcasts a RTMP video stream and publishes a timestamps when motion is detected. Publishing timestamps make it impossible for me to match the entire message via
motionMessage.To make message matching more flexible for various scenarios, I added RegExp matching support for MQTT messages.